Commit 0746a0bc authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Linus Torvalds

proc: use do-while in name_to_int()

Gcc doesn't know that "len" is guaranteed to be >=1 by dcache and
generates standard while-loop prologue duplicating loop condition.

	add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-27 (-27)
	function                                     old     new   delta
	name_to_int                                  104      77     -27

Link: http://lkml.kernel.org/r/20170912195213.GB17730@avx2Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3ee2a199
...@@ -8,7 +8,7 @@ unsigned name_to_int(const struct qstr *qstr) ...@@ -8,7 +8,7 @@ unsigned name_to_int(const struct qstr *qstr)
if (len > 1 && *name == '0') if (len > 1 && *name == '0')
goto out; goto out;
while (len-- > 0) { do {
unsigned c = *name++ - '0'; unsigned c = *name++ - '0';
if (c > 9) if (c > 9)
goto out; goto out;
...@@ -16,7 +16,7 @@ unsigned name_to_int(const struct qstr *qstr) ...@@ -16,7 +16,7 @@ unsigned name_to_int(const struct qstr *qstr)
goto out; goto out;
n *= 10; n *= 10;
n += c; n += c;
} } while (--len > 0);
return n; return n;
out: out:
return ~0U; return ~0U;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment