Commit 07709172 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Helge Deller

fbdev: efifb: Use devm_register_framebuffer()

This simplifies the error handling.
Also the drvdata slot is now unused and can be used for other usecases.
Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 95cdd538
...@@ -449,7 +449,6 @@ static int efifb_probe(struct platform_device *dev) ...@@ -449,7 +449,6 @@ static int efifb_probe(struct platform_device *dev)
err = -ENOMEM; err = -ENOMEM;
goto err_release_mem; goto err_release_mem;
} }
platform_set_drvdata(dev, info);
par = info->par; par = info->par;
info->pseudo_palette = par->pseudo_palette; info->pseudo_palette = par->pseudo_palette;
...@@ -572,7 +571,7 @@ static int efifb_probe(struct platform_device *dev) ...@@ -572,7 +571,7 @@ static int efifb_probe(struct platform_device *dev)
pr_err("efifb: cannot acquire aperture\n"); pr_err("efifb: cannot acquire aperture\n");
goto err_fb_dealloc_cmap; goto err_fb_dealloc_cmap;
} }
err = register_framebuffer(info); err = devm_register_framebuffer(&dev->dev, info);
if (err < 0) { if (err < 0) {
pr_err("efifb: cannot register framebuffer\n"); pr_err("efifb: cannot register framebuffer\n");
goto err_fb_dealloc_cmap; goto err_fb_dealloc_cmap;
...@@ -595,21 +594,12 @@ static int efifb_probe(struct platform_device *dev) ...@@ -595,21 +594,12 @@ static int efifb_probe(struct platform_device *dev)
return err; return err;
} }
static void efifb_remove(struct platform_device *pdev)
{
struct fb_info *info = platform_get_drvdata(pdev);
/* efifb_destroy takes care of info cleanup */
unregister_framebuffer(info);
}
static struct platform_driver efifb_driver = { static struct platform_driver efifb_driver = {
.driver = { .driver = {
.name = "efi-framebuffer", .name = "efi-framebuffer",
.dev_groups = efifb_groups, .dev_groups = efifb_groups,
}, },
.probe = efifb_probe, .probe = efifb_probe,
.remove_new = efifb_remove,
}; };
builtin_platform_driver(efifb_driver); builtin_platform_driver(efifb_driver);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment