Commit 07bbeaf1 authored by Linus Torvalds's avatar Linus Torvalds

ieee1394: fix broken signed char assumption.

"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char".  Which only works if "char" is signed - which it
necessarily isn't.

So make that signedness assumption specific.
parent 184f6eb8
...@@ -38,8 +38,8 @@ struct hpsb_packet { ...@@ -38,8 +38,8 @@ struct hpsb_packet {
/* These are core internal. */ /* These are core internal. */
signed char tlabel; signed char tlabel;
char ack_code; signed char ack_code;
char tcode; unsigned char tcode;
unsigned expect_response:1; unsigned expect_response:1;
unsigned no_waiter:1; unsigned no_waiter:1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment