Commit 0825a6f9 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

mm: use octal not symbolic permissions

mm/*.c files use symbolic and octal styles for permissions.

Using octal and not symbolic permissions is preferred by many as more
readable.

https://lkml.org/lkml/2016/8/2/1945

Prefer the direct use of octal for permissions.

Done using
$ scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace mm/*.c
and some typing.

Before:	 $ git grep -P -w "0[0-7]{3,3}" mm | wc -l
44
After:	 $ git grep -P -w "0[0-7]{3,3}" mm | wc -l
86

Miscellanea:

o Whitespace neatening around these conversions.

Link: http://lkml.kernel.org/r/2e032ef111eebcd4c5952bae86763b541d373469.1522102887.git.joe@perches.comSigned-off-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 14f28f57
...@@ -307,12 +307,10 @@ static int __init init_cleancache(void) ...@@ -307,12 +307,10 @@ static int __init init_cleancache(void)
struct dentry *root = debugfs_create_dir("cleancache", NULL); struct dentry *root = debugfs_create_dir("cleancache", NULL);
if (root == NULL) if (root == NULL)
return -ENXIO; return -ENXIO;
debugfs_create_u64("succ_gets", S_IRUGO, root, &cleancache_succ_gets); debugfs_create_u64("succ_gets", 0444, root, &cleancache_succ_gets);
debugfs_create_u64("failed_gets", S_IRUGO, debugfs_create_u64("failed_gets", 0444, root, &cleancache_failed_gets);
root, &cleancache_failed_gets); debugfs_create_u64("puts", 0444, root, &cleancache_puts);
debugfs_create_u64("puts", S_IRUGO, root, &cleancache_puts); debugfs_create_u64("invalidates", 0444, root, &cleancache_invalidates);
debugfs_create_u64("invalidates", S_IRUGO,
root, &cleancache_invalidates);
#endif #endif
return 0; return 0;
} }
......
...@@ -172,23 +172,18 @@ static void cma_debugfs_add_one(struct cma *cma, int idx) ...@@ -172,23 +172,18 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
tmp = debugfs_create_dir(name, cma_debugfs_root); tmp = debugfs_create_dir(name, cma_debugfs_root);
debugfs_create_file("alloc", S_IWUSR, tmp, cma, debugfs_create_file("alloc", 0200, tmp, cma, &cma_alloc_fops);
&cma_alloc_fops); debugfs_create_file("free", 0200, tmp, cma, &cma_free_fops);
debugfs_create_file("base_pfn", 0444, tmp,
debugfs_create_file("free", S_IWUSR, tmp, cma, &cma->base_pfn, &cma_debugfs_fops);
&cma_free_fops); debugfs_create_file("count", 0444, tmp, &cma->count, &cma_debugfs_fops);
debugfs_create_file("order_per_bit", 0444, tmp,
debugfs_create_file("base_pfn", S_IRUGO, tmp, &cma->order_per_bit, &cma_debugfs_fops);
&cma->base_pfn, &cma_debugfs_fops); debugfs_create_file("used", 0444, tmp, cma, &cma_used_fops);
debugfs_create_file("count", S_IRUGO, tmp, debugfs_create_file("maxchunk", 0444, tmp, cma, &cma_maxchunk_fops);
&cma->count, &cma_debugfs_fops);
debugfs_create_file("order_per_bit", S_IRUGO, tmp,
&cma->order_per_bit, &cma_debugfs_fops);
debugfs_create_file("used", S_IRUGO, tmp, cma, &cma_used_fops);
debugfs_create_file("maxchunk", S_IRUGO, tmp, cma, &cma_maxchunk_fops);
u32s = DIV_ROUND_UP(cma_bitmap_maxno(cma), BITS_PER_BYTE * sizeof(u32)); u32s = DIV_ROUND_UP(cma_bitmap_maxno(cma), BITS_PER_BYTE * sizeof(u32));
debugfs_create_u32_array("bitmap", S_IRUGO, tmp, (u32*)cma->bitmap, u32s); debugfs_create_u32_array("bitmap", 0444, tmp, (u32 *)cma->bitmap, u32s);
} }
static int __init cma_debugfs_init(void) static int __init cma_debugfs_init(void)
......
...@@ -1899,7 +1899,7 @@ static ssize_t sysfs_compact_node(struct device *dev, ...@@ -1899,7 +1899,7 @@ static ssize_t sysfs_compact_node(struct device *dev,
return count; return count;
} }
static DEVICE_ATTR(compact, S_IWUSR, NULL, sysfs_compact_node); static DEVICE_ATTR(compact, 0200, NULL, sysfs_compact_node);
int compaction_register_node(struct node *node) int compaction_register_node(struct node *node)
{ {
......
...@@ -105,7 +105,7 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf) ...@@ -105,7 +105,7 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)
return PAGE_SIZE - size; return PAGE_SIZE - size;
} }
static DEVICE_ATTR(pools, S_IRUGO, show_pools, NULL); static DEVICE_ATTR(pools, 0444, show_pools, NULL);
/** /**
* dma_pool_create - Creates a pool of consistent memory blocks, for dma. * dma_pool_create - Creates a pool of consistent memory blocks, for dma.
......
...@@ -42,7 +42,7 @@ __setup("failslab=", setup_failslab); ...@@ -42,7 +42,7 @@ __setup("failslab=", setup_failslab);
static int __init failslab_debugfs_init(void) static int __init failslab_debugfs_init(void)
{ {
struct dentry *dir; struct dentry *dir;
umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; umode_t mode = S_IFREG | 0600;
dir = fault_create_debugfs_attr("failslab", NULL, &failslab.attr); dir = fault_create_debugfs_attr("failslab", NULL, &failslab.attr);
if (IS_ERR(dir)) if (IS_ERR(dir))
......
...@@ -486,12 +486,11 @@ static int __init init_frontswap(void) ...@@ -486,12 +486,11 @@ static int __init init_frontswap(void)
struct dentry *root = debugfs_create_dir("frontswap", NULL); struct dentry *root = debugfs_create_dir("frontswap", NULL);
if (root == NULL) if (root == NULL)
return -ENXIO; return -ENXIO;
debugfs_create_u64("loads", S_IRUGO, root, &frontswap_loads); debugfs_create_u64("loads", 0444, root, &frontswap_loads);
debugfs_create_u64("succ_stores", S_IRUGO, root, &frontswap_succ_stores); debugfs_create_u64("succ_stores", 0444, root, &frontswap_succ_stores);
debugfs_create_u64("failed_stores", S_IRUGO, root, debugfs_create_u64("failed_stores", 0444, root,
&frontswap_failed_stores); &frontswap_failed_stores);
debugfs_create_u64("invalidates", S_IRUGO, debugfs_create_u64("invalidates", 0444, root, &frontswap_invalidates);
root, &frontswap_invalidates);
#endif #endif
return 0; return 0;
} }
......
...@@ -1809,10 +1809,13 @@ static int __init memblock_init_debugfs(void) ...@@ -1809,10 +1809,13 @@ static int __init memblock_init_debugfs(void)
struct dentry *root = debugfs_create_dir("memblock", NULL); struct dentry *root = debugfs_create_dir("memblock", NULL);
if (!root) if (!root)
return -ENXIO; return -ENXIO;
debugfs_create_file("memory", S_IRUGO, root, &memblock.memory, &memblock_debug_fops); debugfs_create_file("memory", 0444, root,
debugfs_create_file("reserved", S_IRUGO, root, &memblock.reserved, &memblock_debug_fops); &memblock.memory, &memblock_debug_fops);
debugfs_create_file("reserved", 0444, root,
&memblock.reserved, &memblock_debug_fops);
#ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP
debugfs_create_file("physmem", S_IRUGO, root, &memblock.physmem, &memblock_debug_fops); debugfs_create_file("physmem", 0444, root,
&memblock.physmem, &memblock_debug_fops);
#endif #endif
return 0; return 0;
......
...@@ -3061,7 +3061,7 @@ static bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) ...@@ -3061,7 +3061,7 @@ static bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
static int __init fail_page_alloc_debugfs(void) static int __init fail_page_alloc_debugfs(void)
{ {
umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; umode_t mode = S_IFREG | 0600;
struct dentry *dir; struct dentry *dir;
dir = fault_create_debugfs_attr("fail_page_alloc", NULL, dir = fault_create_debugfs_attr("fail_page_alloc", NULL,
......
...@@ -201,7 +201,7 @@ static ssize_t page_idle_bitmap_write(struct file *file, struct kobject *kobj, ...@@ -201,7 +201,7 @@ static ssize_t page_idle_bitmap_write(struct file *file, struct kobject *kobj,
} }
static struct bin_attribute page_idle_bitmap_attr = static struct bin_attribute page_idle_bitmap_attr =
__BIN_ATTR(bitmap, S_IRUSR | S_IWUSR, __BIN_ATTR(bitmap, 0600,
page_idle_bitmap_read, page_idle_bitmap_write, 0); page_idle_bitmap_read, page_idle_bitmap_write, 0);
static struct bin_attribute *page_idle_bin_attrs[] = { static struct bin_attribute *page_idle_bin_attrs[] = {
......
...@@ -631,8 +631,8 @@ static int __init pageowner_init(void) ...@@ -631,8 +631,8 @@ static int __init pageowner_init(void)
return 0; return 0;
} }
dentry = debugfs_create_file("page_owner", S_IRUSR, NULL, dentry = debugfs_create_file("page_owner", 0400, NULL,
NULL, &proc_page_owner_operations); NULL, &proc_page_owner_operations);
return PTR_ERR_OR_ZERO(dentry); return PTR_ERR_OR_ZERO(dentry);
} }
......
...@@ -3013,7 +3013,8 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s ...@@ -3013,7 +3013,8 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
if (len > PAGE_SIZE) if (len > PAGE_SIZE)
return -ENAMETOOLONG; return -ENAMETOOLONG;
inode = shmem_get_inode(dir->i_sb, dir, S_IFLNK|S_IRWXUGO, 0, VM_NORESERVE); inode = shmem_get_inode(dir->i_sb, dir, S_IFLNK | 0777, 0,
VM_NORESERVE);
if (!inode) if (!inode)
return -ENOSPC; return -ENOSPC;
...@@ -3445,7 +3446,7 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root) ...@@ -3445,7 +3446,7 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root)
sbinfo->max_blocks << (PAGE_SHIFT - 10)); sbinfo->max_blocks << (PAGE_SHIFT - 10));
if (sbinfo->max_inodes != shmem_default_max_inodes()) if (sbinfo->max_inodes != shmem_default_max_inodes())
seq_printf(seq, ",nr_inodes=%lu", sbinfo->max_inodes); seq_printf(seq, ",nr_inodes=%lu", sbinfo->max_inodes);
if (sbinfo->mode != (S_IRWXUGO | S_ISVTX)) if (sbinfo->mode != (0777 | S_ISVTX))
seq_printf(seq, ",mode=%03ho", sbinfo->mode); seq_printf(seq, ",mode=%03ho", sbinfo->mode);
if (!uid_eq(sbinfo->uid, GLOBAL_ROOT_UID)) if (!uid_eq(sbinfo->uid, GLOBAL_ROOT_UID))
seq_printf(seq, ",uid=%u", seq_printf(seq, ",uid=%u",
...@@ -3486,7 +3487,7 @@ int shmem_fill_super(struct super_block *sb, void *data, int silent) ...@@ -3486,7 +3487,7 @@ int shmem_fill_super(struct super_block *sb, void *data, int silent)
if (!sbinfo) if (!sbinfo)
return -ENOMEM; return -ENOMEM;
sbinfo->mode = S_IRWXUGO | S_ISVTX; sbinfo->mode = 0777 | S_ISVTX;
sbinfo->uid = current_fsuid(); sbinfo->uid = current_fsuid();
sbinfo->gid = current_fsgid(); sbinfo->gid = current_fsgid();
sb->s_fs_info = sbinfo; sb->s_fs_info = sbinfo;
...@@ -3929,7 +3930,7 @@ static struct file *__shmem_file_setup(struct vfsmount *mnt, const char *name, l ...@@ -3929,7 +3930,7 @@ static struct file *__shmem_file_setup(struct vfsmount *mnt, const char *name, l
d_set_d_op(path.dentry, &anon_ops); d_set_d_op(path.dentry, &anon_ops);
res = ERR_PTR(-ENOSPC); res = ERR_PTR(-ENOSPC);
inode = shmem_get_inode(sb, NULL, S_IFREG | S_IRWXUGO, 0, flags); inode = shmem_get_inode(sb, NULL, S_IFREG | 0777, 0, flags);
if (!inode) if (!inode)
goto put_memory; goto put_memory;
......
...@@ -1243,9 +1243,9 @@ void cache_random_seq_destroy(struct kmem_cache *cachep) ...@@ -1243,9 +1243,9 @@ void cache_random_seq_destroy(struct kmem_cache *cachep)
#if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG) #if defined(CONFIG_SLAB) || defined(CONFIG_SLUB_DEBUG)
#ifdef CONFIG_SLAB #ifdef CONFIG_SLAB
#define SLABINFO_RIGHTS (S_IWUSR | S_IRUSR) #define SLABINFO_RIGHTS (0600)
#else #else
#define SLABINFO_RIGHTS S_IRUSR #define SLABINFO_RIGHTS (0400)
#endif #endif
static void print_slabinfo_header(struct seq_file *m) static void print_slabinfo_header(struct seq_file *m)
......
...@@ -2741,11 +2741,11 @@ static const struct seq_operations vmalloc_op = { ...@@ -2741,11 +2741,11 @@ static const struct seq_operations vmalloc_op = {
static int __init proc_vmalloc_init(void) static int __init proc_vmalloc_init(void)
{ {
if (IS_ENABLED(CONFIG_NUMA)) if (IS_ENABLED(CONFIG_NUMA))
proc_create_seq_private("vmallocinfo", S_IRUSR, NULL, proc_create_seq_private("vmallocinfo", 0400, NULL,
&vmalloc_op, &vmalloc_op,
nr_node_ids * sizeof(unsigned int), NULL); nr_node_ids * sizeof(unsigned int), NULL);
else else
proc_create_seq("vmallocinfo", S_IRUSR, NULL, &vmalloc_op); proc_create_seq("vmallocinfo", 0400, NULL, &vmalloc_op);
return 0; return 0;
} }
module_init(proc_vmalloc_init); module_init(proc_vmalloc_init);
......
...@@ -661,8 +661,9 @@ static void zs_pool_stat_create(struct zs_pool *pool, const char *name) ...@@ -661,8 +661,9 @@ static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
} }
pool->stat_dentry = entry; pool->stat_dentry = entry;
entry = debugfs_create_file("classes", S_IFREG | S_IRUGO, entry = debugfs_create_file("classes", S_IFREG | 0444,
pool->stat_dentry, pool, &zs_stats_size_fops); pool->stat_dentry, pool,
&zs_stats_size_fops);
if (!entry) { if (!entry) {
pr_warn("%s: debugfs file entry <%s> creation failed\n", pr_warn("%s: debugfs file entry <%s> creation failed\n",
name, "classes"); name, "classes");
......
...@@ -1256,26 +1256,26 @@ static int __init zswap_debugfs_init(void) ...@@ -1256,26 +1256,26 @@ static int __init zswap_debugfs_init(void)
if (!zswap_debugfs_root) if (!zswap_debugfs_root)
return -ENOMEM; return -ENOMEM;
debugfs_create_u64("pool_limit_hit", S_IRUGO, debugfs_create_u64("pool_limit_hit", 0444,
zswap_debugfs_root, &zswap_pool_limit_hit); zswap_debugfs_root, &zswap_pool_limit_hit);
debugfs_create_u64("reject_reclaim_fail", S_IRUGO, debugfs_create_u64("reject_reclaim_fail", 0444,
zswap_debugfs_root, &zswap_reject_reclaim_fail); zswap_debugfs_root, &zswap_reject_reclaim_fail);
debugfs_create_u64("reject_alloc_fail", S_IRUGO, debugfs_create_u64("reject_alloc_fail", 0444,
zswap_debugfs_root, &zswap_reject_alloc_fail); zswap_debugfs_root, &zswap_reject_alloc_fail);
debugfs_create_u64("reject_kmemcache_fail", S_IRUGO, debugfs_create_u64("reject_kmemcache_fail", 0444,
zswap_debugfs_root, &zswap_reject_kmemcache_fail); zswap_debugfs_root, &zswap_reject_kmemcache_fail);
debugfs_create_u64("reject_compress_poor", S_IRUGO, debugfs_create_u64("reject_compress_poor", 0444,
zswap_debugfs_root, &zswap_reject_compress_poor); zswap_debugfs_root, &zswap_reject_compress_poor);
debugfs_create_u64("written_back_pages", S_IRUGO, debugfs_create_u64("written_back_pages", 0444,
zswap_debugfs_root, &zswap_written_back_pages); zswap_debugfs_root, &zswap_written_back_pages);
debugfs_create_u64("duplicate_entry", S_IRUGO, debugfs_create_u64("duplicate_entry", 0444,
zswap_debugfs_root, &zswap_duplicate_entry); zswap_debugfs_root, &zswap_duplicate_entry);
debugfs_create_u64("pool_total_size", S_IRUGO, debugfs_create_u64("pool_total_size", 0444,
zswap_debugfs_root, &zswap_pool_total_size); zswap_debugfs_root, &zswap_pool_total_size);
debugfs_create_atomic_t("stored_pages", S_IRUGO, debugfs_create_atomic_t("stored_pages", 0444,
zswap_debugfs_root, &zswap_stored_pages); zswap_debugfs_root, &zswap_stored_pages);
debugfs_create_atomic_t("same_filled_pages", 0444, debugfs_create_atomic_t("same_filled_pages", 0444,
zswap_debugfs_root, &zswap_same_filled_pages); zswap_debugfs_root, &zswap_same_filled_pages);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment