Commit 08855981 authored by Willem de Bruijn's avatar Willem de Bruijn Committed by Jakub Kicinski

selftests/net: ipsec: fix constant out of range

Fix a small compiler warning.

nr_process must be a signed long: it is assigned a signed long by
strtol() and is compared against LONG_MIN and LONG_MAX.

ipsec.c:2280:65:
    error: result of comparison of constant -9223372036854775808
    with expression of type 'unsigned int' is always false
    [-Werror,-Wtautological-constant-out-of-range-compare]

  if ((errno == ERANGE && (nr_process == LONG_MAX || nr_process == LONG_MIN))

Fixes: bc2652b7 ("selftest/net/xfrm: Add test for ipsec tunnel")
Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
Reviewed-by: default avatarDmitry Safonov <0x7f454c46@gmail.com>
Link: https://lore.kernel.org/r/20231124171645.1011043-2-willemdebruijn.kernel@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ccf49ceb
...@@ -2263,7 +2263,7 @@ static int check_results(void) ...@@ -2263,7 +2263,7 @@ static int check_results(void)
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
unsigned int nr_process = 1; long nr_process = 1;
int route_sock = -1, ret = KSFT_SKIP; int route_sock = -1, ret = KSFT_SKIP;
int test_desc_fd[2]; int test_desc_fd[2];
uint32_t route_seq; uint32_t route_seq;
...@@ -2284,7 +2284,7 @@ int main(int argc, char **argv) ...@@ -2284,7 +2284,7 @@ int main(int argc, char **argv)
exit_usage(argv); exit_usage(argv);
} }
if (nr_process > MAX_PROCESSES || !nr_process) { if (nr_process > MAX_PROCESSES || nr_process < 1) {
printk("nr_process should be between [1; %u]", printk("nr_process should be between [1; %u]",
MAX_PROCESSES); MAX_PROCESSES);
exit_usage(argv); exit_usage(argv);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment