Commit 0a615934 authored by Johannes Erdfelt's avatar Johannes Erdfelt Committed by Greg Kroah-Hartman

[PATCH] uhci.c 2.4.19-pre3 erroneous completion callback

uhci.c would call the completion callback when the call to submit_urb
failed. This is a rare situation.

This patch only calls the completion handler if the URB successfully
completed immediately (as in the case of talking to the virtual root
hub).

JE
parent 40bb0d53
...@@ -1594,7 +1594,9 @@ static int uhci_submit_urb(struct urb *urb, int mem_flags) ...@@ -1594,7 +1594,9 @@ static int uhci_submit_urb(struct urb *urb, int mem_flags)
spin_unlock(&urb->lock); spin_unlock(&urb->lock);
spin_unlock_irqrestore(&uhci->urb_list_lock, flags); spin_unlock_irqrestore(&uhci->urb_list_lock, flags);
uhci_call_completion(urb); /* Only call completion if it was successful */
if (!ret)
uhci_call_completion(urb);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment