Commit 0a7c2fda authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Stephen Boyd

clk: sophgo: avoid open-coded 64-bit division

On 32-bit architectures, the 64-bit division leads to a link failure:

arm-linux-gnueabi-ld: drivers/clk/sophgo/clk-cv18xx-pll.o: in function `fpll_calc_rate':
clk-cv18xx-pll.c:(.text.fpll_calc_rate+0x26): undefined reference to `__aeabi_uldivmod'

This one is not called in a fast path, and there is already another div_u64()
variant used in the same function, so convert it to div64_u64_rem().

Fixes: 80fd61ec ("clk: sophgo: Add clock support for CV1800 SoC")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240415134532.3467817-1-arnd@kernel.orgReported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404122344.d5pb2N1I-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202404140310.QEjZKtTN-lkp@intel.com/Reviewed-by: default avatarInochi Amaoto <inochiama@outlook.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent a12069a3
......@@ -205,8 +205,7 @@ static unsigned long fpll_calc_rate(unsigned long parent_rate,
unsigned long rate;
dividend <<= PLL_SYN_FACTOR_DOT_POS - 1;
rate = dividend / factor;
dividend %= factor;
rate = div64_u64_rem(dividend, factor, &dividend);
if (is_full_parent) {
dividend <<= 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment