Commit 0a869e8d authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Eric Anholt

drm/pl111: pl111_vexpress.c: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop there is
no put, thus causing a memory leak. Hence add an of_node_put before the
break.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarEric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190706132742.3250-1-nishkadg.linux@gmail.com
parent 71866a56
...@@ -51,6 +51,7 @@ int pl111_vexpress_clcd_init(struct device *dev, ...@@ -51,6 +51,7 @@ int pl111_vexpress_clcd_init(struct device *dev,
} }
if (of_device_is_compatible(child, "arm,hdlcd")) { if (of_device_is_compatible(child, "arm,hdlcd")) {
has_coretile_hdlcd = true; has_coretile_hdlcd = true;
of_node_put(child);
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment