Commit 0ace247e authored by Bill Pemberton's avatar Bill Pemberton Committed by Greg Kroah-Hartman

staging: hv: remove ASSERT()s in Channel.c

These ASSERT()s serve no purpose other than for debugging.
Signed-off-by: default avatarBill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 002b53ea
...@@ -183,8 +183,8 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize, ...@@ -183,8 +183,8 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
DPRINT_ENTER(VMBUS); DPRINT_ENTER(VMBUS);
/* Aligned to page size */ /* Aligned to page size */
ASSERT(!(SendRingBufferSize & (PAGE_SIZE - 1))); /* ASSERT(!(SendRingBufferSize & (PAGE_SIZE - 1))); */
ASSERT(!(RecvRingBufferSize & (PAGE_SIZE - 1))); /* ASSERT(!(RecvRingBufferSize & (PAGE_SIZE - 1))); */
NewChannel->OnChannelCallback = OnChannelCallback; NewChannel->OnChannelCallback = OnChannelCallback;
NewChannel->ChannelCallbackContext = Context; NewChannel->ChannelCallbackContext = Context;
...@@ -195,7 +195,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize, ...@@ -195,7 +195,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 SendRingBufferSize,
if (!out) if (!out)
return -ENOMEM; return -ENOMEM;
ASSERT(((unsigned long)out & (PAGE_SIZE-1)) == 0); /* ASSERT(((unsigned long)out & (PAGE_SIZE-1)) == 0); */
in = (void *)((unsigned long)out + SendRingBufferSize); in = (void *)((unsigned long)out + SendRingBufferSize);
...@@ -373,7 +373,7 @@ static int VmbusChannelCreateGpadlHeader(void *Kbuffer, u32 Size, ...@@ -373,7 +373,7 @@ static int VmbusChannelCreateGpadlHeader(void *Kbuffer, u32 Size,
int pfnSum, pfnCount, pfnLeft, pfnCurr, pfnSize; int pfnSum, pfnCount, pfnLeft, pfnCurr, pfnSize;
/* ASSERT((kbuffer & (PAGE_SIZE-1)) == 0); */ /* ASSERT((kbuffer & (PAGE_SIZE-1)) == 0); */
ASSERT((Size & (PAGE_SIZE-1)) == 0); /* ASSERT((Size & (PAGE_SIZE-1)) == 0); */
pageCount = Size >> PAGE_SHIFT; pageCount = Size >> PAGE_SHIFT;
pfn = virt_to_phys(Kbuffer) >> PAGE_SHIFT; pfn = virt_to_phys(Kbuffer) >> PAGE_SHIFT;
...@@ -601,7 +601,7 @@ int VmbusChannelTeardownGpadl(struct vmbus_channel *Channel, u32 GpadlHandle) ...@@ -601,7 +601,7 @@ int VmbusChannelTeardownGpadl(struct vmbus_channel *Channel, u32 GpadlHandle)
DPRINT_ENTER(VMBUS); DPRINT_ENTER(VMBUS);
ASSERT(GpadlHandle != 0); /* ASSERT(GpadlHandle != 0); */
info = kmalloc(sizeof(*info) + info = kmalloc(sizeof(*info) +
sizeof(struct vmbus_channel_gpadl_teardown), GFP_KERNEL); sizeof(struct vmbus_channel_gpadl_teardown), GFP_KERNEL);
...@@ -746,7 +746,7 @@ int VmbusChannelSendPacket(struct vmbus_channel *Channel, const void *Buffer, ...@@ -746,7 +746,7 @@ int VmbusChannelSendPacket(struct vmbus_channel *Channel, const void *Buffer,
DumpVmbusChannel(Channel); DumpVmbusChannel(Channel);
ASSERT((packetLenAligned - packetLen) < sizeof(u64)); /* ASSERT((packetLenAligned - packetLen) < sizeof(u64)); */
/* Setup the descriptor */ /* Setup the descriptor */
desc.Type = Type; /* VmbusPacketTypeDataInBand; */ desc.Type = Type; /* VmbusPacketTypeDataInBand; */
...@@ -808,7 +808,7 @@ int VmbusChannelSendPacketPageBuffer(struct vmbus_channel *Channel, ...@@ -808,7 +808,7 @@ int VmbusChannelSendPacketPageBuffer(struct vmbus_channel *Channel,
packetLen = descSize + BufferLen; packetLen = descSize + BufferLen;
packetLenAligned = ALIGN_UP(packetLen, sizeof(u64)); packetLenAligned = ALIGN_UP(packetLen, sizeof(u64));
ASSERT((packetLenAligned - packetLen) < sizeof(u64)); /* ASSERT((packetLenAligned - packetLen) < sizeof(u64)); */
/* Setup the descriptor */ /* Setup the descriptor */
desc.Type = VmbusPacketTypeDataUsingGpaDirect; desc.Type = VmbusPacketTypeDataUsingGpaDirect;
...@@ -878,7 +878,7 @@ int VmbusChannelSendPacketMultiPageBuffer(struct vmbus_channel *Channel, ...@@ -878,7 +878,7 @@ int VmbusChannelSendPacketMultiPageBuffer(struct vmbus_channel *Channel,
packetLen = descSize + BufferLen; packetLen = descSize + BufferLen;
packetLenAligned = ALIGN_UP(packetLen, sizeof(u64)); packetLenAligned = ALIGN_UP(packetLen, sizeof(u64));
ASSERT((packetLenAligned - packetLen) < sizeof(u64)); /* ASSERT((packetLenAligned - packetLen) < sizeof(u64)); */
/* Setup the descriptor */ /* Setup the descriptor */
desc.Type = VmbusPacketTypeDataUsingGpaDirect; desc.Type = VmbusPacketTypeDataUsingGpaDirect;
...@@ -1056,7 +1056,7 @@ int VmbusChannelRecvPacketRaw(struct vmbus_channel *Channel, void *Buffer, ...@@ -1056,7 +1056,7 @@ int VmbusChannelRecvPacketRaw(struct vmbus_channel *Channel, void *Buffer,
void VmbusChannelOnChannelEvent(struct vmbus_channel *Channel) void VmbusChannelOnChannelEvent(struct vmbus_channel *Channel)
{ {
DumpVmbusChannel(Channel); DumpVmbusChannel(Channel);
ASSERT(Channel->OnChannelCallback); /* ASSERT(Channel->OnChannelCallback); */
Channel->OnChannelCallback(Channel->ChannelCallbackContext); Channel->OnChannelCallback(Channel->ChannelCallbackContext);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment