Commit 0b25167d authored by Wolfram Sang's avatar Wolfram Sang Committed by Mauro Carvalho Chehab

media: mn88473: don't check retval after our own assignemt

No need to check a retval after we assigned a constant to it.
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent e6ec19a2
...@@ -661,8 +661,7 @@ static int mn88473_probe(struct i2c_client *client, ...@@ -661,8 +661,7 @@ static int mn88473_probe(struct i2c_client *client,
if (IS_ERR(dev->client[1])) { if (IS_ERR(dev->client[1])) {
ret = PTR_ERR(dev->client[1]); ret = PTR_ERR(dev->client[1]);
dev_err(&client->dev, "I2C registration failed\n"); dev_err(&client->dev, "I2C registration failed\n");
if (ret) goto err_regmap_0_regmap_exit;
goto err_regmap_0_regmap_exit;
} }
dev->regmap[1] = regmap_init_i2c(dev->client[1], &regmap_config); dev->regmap[1] = regmap_init_i2c(dev->client[1], &regmap_config);
if (IS_ERR(dev->regmap[1])) { if (IS_ERR(dev->regmap[1])) {
...@@ -675,8 +674,7 @@ static int mn88473_probe(struct i2c_client *client, ...@@ -675,8 +674,7 @@ static int mn88473_probe(struct i2c_client *client,
if (IS_ERR(dev->client[2])) { if (IS_ERR(dev->client[2])) {
ret = PTR_ERR(dev->client[2]); ret = PTR_ERR(dev->client[2]);
dev_err(&client->dev, "2nd I2C registration failed\n"); dev_err(&client->dev, "2nd I2C registration failed\n");
if (ret) goto err_regmap_1_regmap_exit;
goto err_regmap_1_regmap_exit;
} }
dev->regmap[2] = regmap_init_i2c(dev->client[2], &regmap_config); dev->regmap[2] = regmap_init_i2c(dev->client[2], &regmap_config);
if (IS_ERR(dev->regmap[2])) { if (IS_ERR(dev->regmap[2])) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment