Commit 0b39536c authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Bartosz Golaszewski

gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 76c47d14 ("gpio: mpc8xxx: Add ACPI support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent df0cc57e
...@@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev) ...@@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
} }
mpc8xxx_gc->irqn = platform_get_irq(pdev, 0); mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
if (!mpc8xxx_gc->irqn) if (mpc8xxx_gc->irqn < 0)
return 0; return mpc8xxx_gc->irqn;
mpc8xxx_gc->irq = irq_domain_create_linear(fwnode, mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
MPC8XXX_GPIO_PINS, MPC8XXX_GPIO_PINS,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment