Commit 0c017f09 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde

can: bittiming: can_sjw_check(): report error via netlink and harmonize error value

If the user space has supplied an invalid SJW value (greater than the
maximum SJW value), report -EINVAL instead of -ERANGE, this better
matches the actual meaning of the error value.

Additionally report an error message via netlink to the user space.

Link: https://lore.kernel.org/all/20230202110854.2318594-13-mkl@pengutronix.deSigned-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent de82d618
...@@ -18,8 +18,11 @@ void can_sjw_set_default(struct can_bittiming *bt) ...@@ -18,8 +18,11 @@ void can_sjw_set_default(struct can_bittiming *bt)
int can_sjw_check(const struct net_device *dev, const struct can_bittiming *bt, int can_sjw_check(const struct net_device *dev, const struct can_bittiming *bt,
const struct can_bittiming_const *btc, struct netlink_ext_ack *extack) const struct can_bittiming_const *btc, struct netlink_ext_ack *extack)
{ {
if (bt->sjw > btc->sjw_max) if (bt->sjw > btc->sjw_max) {
return -ERANGE; NL_SET_ERR_MSG_FMT(extack, "sjw: %u greater than max sjw: %u",
bt->sjw, btc->sjw_max);
return -EINVAL;
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment