Commit 0c4395fb authored by Roberto Sassu's avatar Roberto Sassu Committed by Mimi Zohar

evm: Fix possible memory leak in evm_calc_hmac_or_hash()

Don't immediately return if the signature is portable and security.ima is
not present. Just set error so that memory allocated is freed before
returning from evm_calc_hmac_or_hash().

Fixes: 50b97748 ("EVM: Add support for portable signature format")
Signed-off-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
parent b59fda44
...@@ -241,7 +241,7 @@ static int evm_calc_hmac_or_hash(struct dentry *dentry, ...@@ -241,7 +241,7 @@ static int evm_calc_hmac_or_hash(struct dentry *dentry,
/* Portable EVM signatures must include an IMA hash */ /* Portable EVM signatures must include an IMA hash */
if (type == EVM_XATTR_PORTABLE_DIGSIG && !ima_present) if (type == EVM_XATTR_PORTABLE_DIGSIG && !ima_present)
return -EPERM; error = -EPERM;
out: out:
kfree(xattr_value); kfree(xattr_value);
kfree(desc); kfree(desc);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment