Commit 0c7beb2d authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Kalle Valo

zd1211rw: use struct_size() helper

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.

So, replace code of the following form:

sizeof(struct usb_req_write_regs) + count * sizeof(struct reg_data)

with:

struct_size(req, reg_writes, count)

This code was detected with the help of Coccinelle.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent ae187ba9
...@@ -1917,8 +1917,7 @@ int zd_usb_iowrite16v_async(struct zd_usb *usb, const struct zd_ioreq16 *ioreqs, ...@@ -1917,8 +1917,7 @@ int zd_usb_iowrite16v_async(struct zd_usb *usb, const struct zd_ioreq16 *ioreqs,
if (!urb) if (!urb)
return -ENOMEM; return -ENOMEM;
req_len = sizeof(struct usb_req_write_regs) + req_len = struct_size(req, reg_writes, count);
count * sizeof(struct reg_data);
req = kmalloc(req_len, GFP_KERNEL); req = kmalloc(req_len, GFP_KERNEL);
if (!req) { if (!req) {
r = -ENOMEM; r = -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment