Commit 0cd2135c authored by Peng Li's avatar Peng Li Committed by David S. Miller

net: pc300too: replace comparison to NULL with "!card->plxbase"

According to the chackpatch.pl, comparison to NULL could
be written "!card->plxbase".
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ae644048
...@@ -298,7 +298,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev, ...@@ -298,7 +298,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
} }
card = kzalloc(sizeof(card_t), GFP_KERNEL); card = kzalloc(sizeof(card_t), GFP_KERNEL);
if (card == NULL) { if (!card) {
pci_release_regions(pdev); pci_release_regions(pdev);
pci_disable_device(pdev); pci_disable_device(pdev);
return -ENOBUFS; return -ENOBUFS;
...@@ -322,9 +322,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev, ...@@ -322,9 +322,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
ramphys = pci_resource_start(pdev, 3) & PCI_BASE_ADDRESS_MEM_MASK; ramphys = pci_resource_start(pdev, 3) & PCI_BASE_ADDRESS_MEM_MASK;
card->rambase = pci_ioremap_bar(pdev, 3); card->rambase = pci_ioremap_bar(pdev, 3);
if (card->plxbase == NULL || if (!card->plxbase || !card->scabase || !card->rambase) {
card->scabase == NULL ||
card->rambase == NULL) {
pr_err("ioremap() failed\n"); pr_err("ioremap() failed\n");
pc300_pci_remove_one(pdev); pc300_pci_remove_one(pdev);
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment