Commit 0d5e34c1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

dm zoned: fix potential NULL dereference in dmz_do_reclaim()

[ Upstream commit e0702d90 ]

This function is supposed to return error pointers so it matches the
dmz_get_rnd_zone_for_reclaim() function.  The current code could lead to
a NULL dereference in dmz_do_reclaim()

Fixes: b234c6d7 ("dm zoned: improve error handling in reclaim")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarDmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 655bb2c4
...@@ -1579,7 +1579,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd) ...@@ -1579,7 +1579,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd)
struct dm_zone *zone; struct dm_zone *zone;
if (list_empty(&zmd->map_seq_list)) if (list_empty(&zmd->map_seq_list))
return NULL; return ERR_PTR(-EBUSY);
list_for_each_entry(zone, &zmd->map_seq_list, link) { list_for_each_entry(zone, &zmd->map_seq_list, link) {
if (!zone->bzone) if (!zone->bzone)
...@@ -1588,7 +1588,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd) ...@@ -1588,7 +1588,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd)
return zone; return zone;
} }
return NULL; return ERR_PTR(-EBUSY);
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment