Commit 0d769a52 authored by Takashi Iwai's avatar Takashi Iwai

sound: sound_firmware: Fix invalid use of vfs_read()

It should use kernel_read() instead of vfs_read() to load a firmware
binary onto the kernel pages.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 574d69c2
...@@ -12,7 +12,6 @@ static int do_mod_firmware_load(const char *fn, char **fp) ...@@ -12,7 +12,6 @@ static int do_mod_firmware_load(const char *fn, char **fp)
struct file* filp; struct file* filp;
long l; long l;
char *dp; char *dp;
loff_t pos;
filp = filp_open(fn, 0, 0); filp = filp_open(fn, 0, 0);
if (IS_ERR(filp)) if (IS_ERR(filp))
...@@ -34,8 +33,7 @@ static int do_mod_firmware_load(const char *fn, char **fp) ...@@ -34,8 +33,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
fput(filp); fput(filp);
return 0; return 0;
} }
pos = 0; if (kernel_read(filp, 0, dp, l) != l)
if (vfs_read(filp, dp, l, &pos) != l)
{ {
printk(KERN_INFO "Failed to read '%s'.\n", fn); printk(KERN_INFO "Failed to read '%s'.\n", fn);
vfree(dp); vfree(dp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment