Commit 0de6e194 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron

iio: adc: qcom-pm8xxx-xoadc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230919174931.1417681-19-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 5253a5cc
...@@ -957,7 +957,7 @@ static int pm8xxx_xoadc_probe(struct platform_device *pdev) ...@@ -957,7 +957,7 @@ static int pm8xxx_xoadc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int pm8xxx_xoadc_remove(struct platform_device *pdev) static void pm8xxx_xoadc_remove(struct platform_device *pdev)
{ {
struct iio_dev *indio_dev = platform_get_drvdata(pdev); struct iio_dev *indio_dev = platform_get_drvdata(pdev);
struct pm8xxx_xoadc *adc = iio_priv(indio_dev); struct pm8xxx_xoadc *adc = iio_priv(indio_dev);
...@@ -965,8 +965,6 @@ static int pm8xxx_xoadc_remove(struct platform_device *pdev) ...@@ -965,8 +965,6 @@ static int pm8xxx_xoadc_remove(struct platform_device *pdev)
iio_device_unregister(indio_dev); iio_device_unregister(indio_dev);
regulator_disable(adc->vref); regulator_disable(adc->vref);
return 0;
} }
static const struct xoadc_variant pm8018_variant = { static const struct xoadc_variant pm8018_variant = {
...@@ -1019,7 +1017,7 @@ static struct platform_driver pm8xxx_xoadc_driver = { ...@@ -1019,7 +1017,7 @@ static struct platform_driver pm8xxx_xoadc_driver = {
.of_match_table = pm8xxx_xoadc_id_table, .of_match_table = pm8xxx_xoadc_id_table,
}, },
.probe = pm8xxx_xoadc_probe, .probe = pm8xxx_xoadc_probe,
.remove = pm8xxx_xoadc_remove, .remove_new = pm8xxx_xoadc_remove,
}; };
module_platform_driver(pm8xxx_xoadc_driver); module_platform_driver(pm8xxx_xoadc_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment