Commit 0e185b79 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Greg Kroah-Hartman

USB: Memory leak in drivers/usb/serial/airprime.c

the commit
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=5dda171202f94127e49c12daf780cdae1b4e668b
added a memory leak.  In case we cant allocate an urb, we dont free the
buffer and leak it.  Coverity id #1438
Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Acked-by: default avatarAndy Gay <andy@andynet.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent c0fc0ee0
...@@ -134,6 +134,7 @@ static int airprime_open(struct usb_serial_port *port, struct file *filp) ...@@ -134,6 +134,7 @@ static int airprime_open(struct usb_serial_port *port, struct file *filp)
} }
urb = usb_alloc_urb(0, GFP_KERNEL); urb = usb_alloc_urb(0, GFP_KERNEL);
if (!urb) { if (!urb) {
kfree(buffer);
dev_err(&port->dev, "%s - no more urbs?\n", dev_err(&port->dev, "%s - no more urbs?\n",
__FUNCTION__); __FUNCTION__);
result = -ENOMEM; result = -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment