Commit 0e73fc9a authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: sctp: fix array overrun read on sctp_timer_tbl

The comparison on the timeout can lead to an array overrun
read on sctp_timer_tbl because of an off-by-one error. Fix
this by using < instead of <= and also compare to the array
size rather than SCTP_EVENT_TIMEOUT_MAX.

Fixes CoverityScan CID#1397639 ("Out-of-bounds read")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e363116b
...@@ -166,7 +166,7 @@ static const char *const sctp_timer_tbl[] = { ...@@ -166,7 +166,7 @@ static const char *const sctp_timer_tbl[] = {
/* Lookup timer debug name. */ /* Lookup timer debug name. */
const char *sctp_tname(const sctp_subtype_t id) const char *sctp_tname(const sctp_subtype_t id)
{ {
if (id.timeout <= SCTP_EVENT_TIMEOUT_MAX) if (id.timeout < ARRAY_SIZE(sctp_timer_tbl))
return sctp_timer_tbl[id.timeout]; return sctp_timer_tbl[id.timeout];
return "unknown_timer"; return "unknown_timer";
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment