Commit 0fbf8ed9 authored by Jesper Juhl's avatar Jesper Juhl Committed by Jiri Kosina

HID: hid-picolcd: Fix memory leak in picolcd_debug_out_report()

We have a memory leak in drivers/hid/hid-picolcd.c::picolcd_debug_out_report()
in an error path..  We are not always freeing the memory allocated to
'buff' - this patch makes sure we always kfree() what we allocate with
kmalloc() when it is no longer needed.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 86280a20
...@@ -1867,6 +1867,7 @@ static void picolcd_debug_out_report(struct picolcd_data *data, ...@@ -1867,6 +1867,7 @@ static void picolcd_debug_out_report(struct picolcd_data *data,
report->id, raw_size); report->id, raw_size);
hid_debug_event(hdev, buff); hid_debug_event(hdev, buff);
if (raw_size + 5 > sizeof(raw_data)) { if (raw_size + 5 > sizeof(raw_data)) {
kfree(buff);
hid_debug_event(hdev, " TOO BIG\n"); hid_debug_event(hdev, " TOO BIG\n");
return; return;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment