Commit 10a47e0f authored by Quentin Monnet's avatar Quentin Monnet Committed by David S. Miller

net: sched: cls_u32: propagate extack support for filter offload

Propagate the extack pointer from the `->change()` classifier operation
to the function used for filter replacement in cls_u32. This makes it
possible to use netlink extack messages in the future at replacement
time for this filter, although it is not used at this point.
Signed-off-by: default avatarQuentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 02798140
...@@ -501,7 +501,7 @@ static void u32_clear_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h) ...@@ -501,7 +501,7 @@ static void u32_clear_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h)
} }
static int u32_replace_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h, static int u32_replace_hw_hnode(struct tcf_proto *tp, struct tc_u_hnode *h,
u32 flags) u32 flags, struct netlink_ext_ack *extack)
{ {
struct tcf_block *block = tp->chain->block; struct tcf_block *block = tp->chain->block;
struct tc_cls_u32_offload cls_u32 = {}; struct tc_cls_u32_offload cls_u32 = {};
...@@ -543,7 +543,7 @@ static void u32_remove_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n) ...@@ -543,7 +543,7 @@ static void u32_remove_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n)
} }
static int u32_replace_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n, static int u32_replace_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n,
u32 flags) u32 flags, struct netlink_ext_ack *extack)
{ {
struct tcf_block *block = tp->chain->block; struct tcf_block *block = tp->chain->block;
struct tc_cls_u32_offload cls_u32 = {}; struct tc_cls_u32_offload cls_u32 = {};
...@@ -965,7 +965,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, ...@@ -965,7 +965,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
return err; return err;
} }
err = u32_replace_hw_knode(tp, new, flags); err = u32_replace_hw_knode(tp, new, flags, extack);
if (err) { if (err) {
u32_destroy_key(tp, new, false); u32_destroy_key(tp, new, false);
return err; return err;
...@@ -1016,7 +1016,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, ...@@ -1016,7 +1016,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
ht->prio = tp->prio; ht->prio = tp->prio;
idr_init(&ht->handle_idr); idr_init(&ht->handle_idr);
err = u32_replace_hw_hnode(tp, ht, flags); err = u32_replace_hw_hnode(tp, ht, flags, extack);
if (err) { if (err) {
idr_remove_ext(&tp_c->handle_idr, handle); idr_remove_ext(&tp_c->handle_idr, handle);
kfree(ht); kfree(ht);
...@@ -1122,7 +1122,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, ...@@ -1122,7 +1122,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
struct tc_u_knode __rcu **ins; struct tc_u_knode __rcu **ins;
struct tc_u_knode *pins; struct tc_u_knode *pins;
err = u32_replace_hw_knode(tp, n, flags); err = u32_replace_hw_knode(tp, n, flags, extack);
if (err) if (err)
goto errhw; goto errhw;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment