Commit 12112293 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Corey Minyard

ipmi_ssif: Fix uninitialized variable issue

Currently, function ssif_remove returns _rv_, which is a variable that
is never initialized.

Fix this by removing variable _rv_ and return 0 instead.

Addresses-Coverity-ID: 1467999 ("Uninitialized scalar variable")
Fixes: 6a0d23ed ("ipmi: ipmi_unregister_smi() cannot fail, have it
return void")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 6b2e54f7
...@@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client) ...@@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client)
struct ssif_info *ssif_info = i2c_get_clientdata(client); struct ssif_info *ssif_info = i2c_get_clientdata(client);
struct ipmi_smi *intf; struct ipmi_smi *intf;
struct ssif_addr_info *addr_info; struct ssif_addr_info *addr_info;
int rv;
if (!ssif_info) if (!ssif_info)
return 0; return 0;
...@@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client) ...@@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client)
} }
} }
return rv; return 0;
} }
static int do_cmd(struct i2c_client *client, int len, unsigned char *msg, static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment