Commit 1386f7a3 authored by Mateusz Nosek's avatar Mateusz Nosek Committed by Linus Torvalds

mm/dmapool.c: micro-optimisation remove unnecessary branch

Previously there was a check if 'size' is aligned to 'align' and if not
then it was aligned.  This check was expensive as both branch and division
are expensive instructions in most architectures.  'ALIGN' function on
already aligned value will not change it, and as it is cheaper than branch
+ division it can be executed all the time and branch can be removed.
Signed-off-by: default avatarMateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200320173317.26408-1-mateusznosek0@gmail.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1d90b649
...@@ -144,9 +144,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, ...@@ -144,9 +144,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
else if (size < 4) else if (size < 4)
size = 4; size = 4;
if ((size % align) != 0) size = ALIGN(size, align);
size = ALIGN(size, align);
allocation = max_t(size_t, size, PAGE_SIZE); allocation = max_t(size_t, size, PAGE_SIZE);
if (!boundary) if (!boundary)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment