Commit 14002089 authored by Ioana Ciornei's avatar Ioana Ciornei Committed by Jakub Kicinski

dpaa2-mac: remove a comment regarding pause settings

The MC firmware takes these PAUSE/ASYM_PAUSE flags provided by the
driver, transforms them back into rx/tx pause enablement status and
applies them to hardware. We are not losing information by this
transformation, thus remove the comment.
Signed-off-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ca763340
...@@ -181,9 +181,6 @@ static void dpaa2_mac_link_up(struct phylink_config *config, ...@@ -181,9 +181,6 @@ static void dpaa2_mac_link_up(struct phylink_config *config,
else if (duplex == DUPLEX_FULL) else if (duplex == DUPLEX_FULL)
dpmac_state->options &= ~DPMAC_LINK_OPT_HALF_DUPLEX; dpmac_state->options &= ~DPMAC_LINK_OPT_HALF_DUPLEX;
/* This is lossy; the firmware really should take the pause
* enablement status rather than pause/asym pause status.
*/
if (rx_pause) if (rx_pause)
dpmac_state->options |= DPMAC_LINK_OPT_PAUSE; dpmac_state->options |= DPMAC_LINK_OPT_PAUSE;
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment