Commit 14c49dd0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Vinod Koul

dmaengine: imx-dma: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919133207.1400430-19-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6e1b4a90
...@@ -1216,7 +1216,7 @@ static void imxdma_free_irq(struct platform_device *pdev, struct imxdma_engine * ...@@ -1216,7 +1216,7 @@ static void imxdma_free_irq(struct platform_device *pdev, struct imxdma_engine *
} }
} }
static int imxdma_remove(struct platform_device *pdev) static void imxdma_remove(struct platform_device *pdev)
{ {
struct imxdma_engine *imxdma = platform_get_drvdata(pdev); struct imxdma_engine *imxdma = platform_get_drvdata(pdev);
...@@ -1229,8 +1229,6 @@ static int imxdma_remove(struct platform_device *pdev) ...@@ -1229,8 +1229,6 @@ static int imxdma_remove(struct platform_device *pdev)
clk_disable_unprepare(imxdma->dma_ipg); clk_disable_unprepare(imxdma->dma_ipg);
clk_disable_unprepare(imxdma->dma_ahb); clk_disable_unprepare(imxdma->dma_ahb);
return 0;
} }
static struct platform_driver imxdma_driver = { static struct platform_driver imxdma_driver = {
...@@ -1238,7 +1236,7 @@ static struct platform_driver imxdma_driver = { ...@@ -1238,7 +1236,7 @@ static struct platform_driver imxdma_driver = {
.name = "imx-dma", .name = "imx-dma",
.of_match_table = imx_dma_of_dev_id, .of_match_table = imx_dma_of_dev_id,
}, },
.remove = imxdma_remove, .remove_new = imxdma_remove,
}; };
static int __init imxdma_module_init(void) static int __init imxdma_module_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment