Commit 14eb76f7 authored by Ville Syrjälä's avatar Ville Syrjälä

drm/i915/fbc: s/false/0/

intel_fbc_check_plane() is supposed to an int, not a boolean.
So replace the bogus 'return false's with the correct 'return 0's.
These were accidental copy-paste mistakes when the code got moved
into intel_fbc_check_plane() from somewhere else tht did return
a boolean.

No functional issue here since false==0.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220413152852.7336-2-ville.syrjala@linux.intel.comReviewed-by: default avatarManasi Navare <manasi.d.navare@intel.com>
parent 3e1faae3
...@@ -1094,7 +1094,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state, ...@@ -1094,7 +1094,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
*/ */
if (DISPLAY_VER(i915) >= 12 && crtc_state->has_psr2) { if (DISPLAY_VER(i915) >= 12 && crtc_state->has_psr2) {
plane_state->no_fbc_reason = "PSR2 enabled"; plane_state->no_fbc_reason = "PSR2 enabled";
return false; return 0;
} }
if (!pixel_format_is_valid(plane_state)) { if (!pixel_format_is_valid(plane_state)) {
...@@ -1120,7 +1120,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state, ...@@ -1120,7 +1120,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE && if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
fb->format->has_alpha) { fb->format->has_alpha) {
plane_state->no_fbc_reason = "per-pixel alpha not supported"; plane_state->no_fbc_reason = "per-pixel alpha not supported";
return false; return 0;
} }
if (!intel_fbc_hw_tracking_covers_screen(plane_state)) { if (!intel_fbc_hw_tracking_covers_screen(plane_state)) {
...@@ -1136,7 +1136,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state, ...@@ -1136,7 +1136,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
if (DISPLAY_VER(i915) >= 9 && if (DISPLAY_VER(i915) >= 9 &&
plane_state->view.color_plane[0].y & 3) { plane_state->view.color_plane[0].y & 3) {
plane_state->no_fbc_reason = "plane start Y offset misaligned"; plane_state->no_fbc_reason = "plane start Y offset misaligned";
return false; return 0;
} }
/* Wa_22010751166: icl, ehl, tgl, dg1, rkl */ /* Wa_22010751166: icl, ehl, tgl, dg1, rkl */
...@@ -1144,7 +1144,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state, ...@@ -1144,7 +1144,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
(plane_state->view.color_plane[0].y + (plane_state->view.color_plane[0].y +
(drm_rect_height(&plane_state->uapi.src) >> 16)) & 3) { (drm_rect_height(&plane_state->uapi.src) >> 16)) & 3) {
plane_state->no_fbc_reason = "plane end Y offset misaligned"; plane_state->no_fbc_reason = "plane end Y offset misaligned";
return false; return 0;
} }
/* WaFbcExceedCdClockThreshold:hsw,bdw */ /* WaFbcExceedCdClockThreshold:hsw,bdw */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment