Commit 15b413d9 authored by Vaibhav Gupta's avatar Vaibhav Gupta Committed by Mark Brown

spi: spi-topcliff-pch: drop call to wakeup-disable

Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)

This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.

Fixes: f185bcc7 ("spi: spi-topcliff-pch: use generic power management")
Reported-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200727172936.661567-1-vaibhavgupta40@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent aa9e862d
...@@ -1652,8 +1652,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev) ...@@ -1652,8 +1652,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
dev_dbg(dev, "%s ENTRY\n", __func__); dev_dbg(dev, "%s ENTRY\n", __func__);
device_wakeup_disable(dev);
/* set suspend status to false */ /* set suspend status to false */
pd_dev_save->board_dat->suspend_sts = false; pd_dev_save->board_dat->suspend_sts = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment