Commit 15f44da0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman

spmi: hisi-spmi-controller: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Link: https://lore.kernel.org/r/20230306073446.2194048-2-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20230413223834.4084793-2-sboyd@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4ccb0fc2
...@@ -324,13 +324,12 @@ static int spmi_controller_probe(struct platform_device *pdev) ...@@ -324,13 +324,12 @@ static int spmi_controller_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int spmi_del_controller(struct platform_device *pdev) static void spmi_del_controller(struct platform_device *pdev)
{ {
struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct spmi_controller *ctrl = platform_get_drvdata(pdev);
spmi_controller_remove(ctrl); spmi_controller_remove(ctrl);
spmi_controller_put(ctrl); spmi_controller_put(ctrl);
return 0;
} }
static const struct of_device_id spmi_controller_match_table[] = { static const struct of_device_id spmi_controller_match_table[] = {
...@@ -343,7 +342,7 @@ MODULE_DEVICE_TABLE(of, spmi_controller_match_table); ...@@ -343,7 +342,7 @@ MODULE_DEVICE_TABLE(of, spmi_controller_match_table);
static struct platform_driver spmi_controller_driver = { static struct platform_driver spmi_controller_driver = {
.probe = spmi_controller_probe, .probe = spmi_controller_probe,
.remove = spmi_del_controller, .remove_new = spmi_del_controller,
.driver = { .driver = {
.name = "hisi_spmi_controller", .name = "hisi_spmi_controller",
.of_match_table = spmi_controller_match_table, .of_match_table = spmi_controller_match_table,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment