Commit 1678f8d8 authored by Linus Torvalds's avatar Linus Torvalds

Merge tag 'vfs-6.8-rc7.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs

Pull vfs fixes from Christian Brauner:
 "Two small fixes:

   - Fix an endless loop during afs directory iteration caused by not
     skipping silly-rename files correctly.

   - Fix reporting of completion events for aio causing leaks in
     userspace. This is based on the fix last week as it's now possible
     to recognize aio events submitted through the old aio interface"

* tag 'vfs-6.8-rc7.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs:
  fs/aio: Make io_cancel() generate completions again
  afs: Fix endless loop in directory parsing
parents 17ba5660 54cbc058
...@@ -479,8 +479,10 @@ static int afs_dir_iterate_block(struct afs_vnode *dvnode, ...@@ -479,8 +479,10 @@ static int afs_dir_iterate_block(struct afs_vnode *dvnode,
dire->u.name[0] == '.' && dire->u.name[0] == '.' &&
ctx->actor != afs_lookup_filldir && ctx->actor != afs_lookup_filldir &&
ctx->actor != afs_lookup_one_filldir && ctx->actor != afs_lookup_one_filldir &&
memcmp(dire->u.name, ".__afs", 6) == 0) memcmp(dire->u.name, ".__afs", 6) == 0) {
ctx->pos = blkoff + next * sizeof(union afs_xdr_dirent);
continue; continue;
}
/* found the next entry */ /* found the next entry */
if (!dir_emit(ctx, dire->u.name, nlen, if (!dir_emit(ctx, dire->u.name, nlen,
......
...@@ -2165,14 +2165,11 @@ COMPAT_SYSCALL_DEFINE3(io_submit, compat_aio_context_t, ctx_id, ...@@ -2165,14 +2165,11 @@ COMPAT_SYSCALL_DEFINE3(io_submit, compat_aio_context_t, ctx_id,
#endif #endif
/* sys_io_cancel: /* sys_io_cancel:
* Attempts to cancel an iocb previously passed to io_submit. If * Attempts to cancel an iocb previously passed to io_submit(). If the
* the operation is successfully cancelled, the resulting event is * operation is successfully cancelled 0 is returned. May fail with
* copied into the memory pointed to by result without being placed * -EFAULT if any of the data structures pointed to are invalid. May
* into the completion queue and 0 is returned. May fail with * fail with -EINVAL if aio_context specified by ctx_id is invalid. Will
* -EFAULT if any of the data structures pointed to are invalid. * fail with -ENOSYS if not implemented.
* May fail with -EINVAL if aio_context specified by ctx_id is
* invalid. May fail with -EAGAIN if the iocb specified was not
* cancelled. Will fail with -ENOSYS if not implemented.
*/ */
SYSCALL_DEFINE3(io_cancel, aio_context_t, ctx_id, struct iocb __user *, iocb, SYSCALL_DEFINE3(io_cancel, aio_context_t, ctx_id, struct iocb __user *, iocb,
struct io_event __user *, result) struct io_event __user *, result)
...@@ -2203,14 +2200,12 @@ SYSCALL_DEFINE3(io_cancel, aio_context_t, ctx_id, struct iocb __user *, iocb, ...@@ -2203,14 +2200,12 @@ SYSCALL_DEFINE3(io_cancel, aio_context_t, ctx_id, struct iocb __user *, iocb,
} }
spin_unlock_irq(&ctx->ctx_lock); spin_unlock_irq(&ctx->ctx_lock);
if (!ret) { /*
/* * The result argument is no longer used - the io_event is always
* The result argument is no longer used - the io_event is * delivered via the ring buffer.
* always delivered via the ring buffer. -EINPROGRESS indicates */
* cancellation is progress: if (ret == 0 && kiocb->rw.ki_flags & IOCB_AIO_RW)
*/ aio_complete_rw(&kiocb->rw, -EINTR);
ret = -EINPROGRESS;
}
percpu_ref_put(&ctx->users); percpu_ref_put(&ctx->users);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment