Commit 17eb8190 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman

usb: phy: twl6030: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230319092428.283054-12-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d95a0ce2
...@@ -409,7 +409,7 @@ static int twl6030_usb_probe(struct platform_device *pdev) ...@@ -409,7 +409,7 @@ static int twl6030_usb_probe(struct platform_device *pdev)
return status; return status;
} }
static int twl6030_usb_remove(struct platform_device *pdev) static void twl6030_usb_remove(struct platform_device *pdev)
{ {
struct twl6030_usb *twl = platform_get_drvdata(pdev); struct twl6030_usb *twl = platform_get_drvdata(pdev);
...@@ -422,8 +422,6 @@ static int twl6030_usb_remove(struct platform_device *pdev) ...@@ -422,8 +422,6 @@ static int twl6030_usb_remove(struct platform_device *pdev)
free_irq(twl->irq2, twl); free_irq(twl->irq2, twl);
regulator_put(twl->usb3v3); regulator_put(twl->usb3v3);
cancel_work_sync(&twl->set_vbus_work); cancel_work_sync(&twl->set_vbus_work);
return 0;
} }
static const struct of_device_id twl6030_usb_id_table[] = { static const struct of_device_id twl6030_usb_id_table[] = {
...@@ -434,7 +432,7 @@ MODULE_DEVICE_TABLE(of, twl6030_usb_id_table); ...@@ -434,7 +432,7 @@ MODULE_DEVICE_TABLE(of, twl6030_usb_id_table);
static struct platform_driver twl6030_usb_driver = { static struct platform_driver twl6030_usb_driver = {
.probe = twl6030_usb_probe, .probe = twl6030_usb_probe,
.remove = twl6030_usb_remove, .remove_new = twl6030_usb_remove,
.driver = { .driver = {
.name = "twl6030_usb", .name = "twl6030_usb",
.of_match_table = of_match_ptr(twl6030_usb_id_table), .of_match_table = of_match_ptr(twl6030_usb_id_table),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment