Commit 17ff204c authored by Nuno Sá's avatar Nuno Sá Committed by Jonathan Cameron

iio: adis16209: Use Managed device functions

Use the adis managed device functions to setup the buffer and the trigger.
The ultimate goal will be to completely drop the non devm version from
the lib.

Since we are here, drop the `.remove` callback by further using devm
functions.
Signed-off-by: default avatarNuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20200915120258.161587-3-nuno.sa@analog.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent b79a22ee
...@@ -291,33 +291,15 @@ static int adis16209_probe(struct spi_device *spi) ...@@ -291,33 +291,15 @@ static int adis16209_probe(struct spi_device *spi)
if (ret) if (ret)
return ret; return ret;
ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL); ret = devm_adis_setup_buffer_and_trigger(st, indio_dev, NULL);
if (ret) if (ret)
return ret; return ret;
ret = adis_initial_startup(st); ret = adis_initial_startup(st);
if (ret) if (ret)
goto error_cleanup_buffer_trigger; return ret;
ret = iio_device_register(indio_dev);
if (ret)
goto error_cleanup_buffer_trigger;
return 0;
error_cleanup_buffer_trigger:
adis_cleanup_buffer_and_trigger(st, indio_dev);
return ret;
}
static int adis16209_remove(struct spi_device *spi)
{
struct iio_dev *indio_dev = spi_get_drvdata(spi);
struct adis *st = iio_priv(indio_dev);
iio_device_unregister(indio_dev);
adis_cleanup_buffer_and_trigger(st, indio_dev);
return 0; return devm_iio_device_register(&spi->dev, indio_dev);
} }
static struct spi_driver adis16209_driver = { static struct spi_driver adis16209_driver = {
...@@ -325,7 +307,6 @@ static struct spi_driver adis16209_driver = { ...@@ -325,7 +307,6 @@ static struct spi_driver adis16209_driver = {
.name = "adis16209", .name = "adis16209",
}, },
.probe = adis16209_probe, .probe = adis16209_probe,
.remove = adis16209_remove,
}; };
module_spi_driver(adis16209_driver); module_spi_driver(adis16209_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment