Commit 18a8cc98 authored by Alexander Duyck's avatar Alexander Duyck Committed by Jeff Kirsher

ixgbe: Fix output from ixgbe_dump

I just found that when we had changed the Rx path to check for length
instead of the DD bit we introduced an issue in ixgbe_dump since we were no
longer clearing the status bits.

To correct this I am updating ixgbe_dump to look for the length bits in the
descriptor since that is what we are using in the Rx path.

Fixes: c3630cc4 ("ixgbe: Use length to determine if descriptor is done")
Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 541ea69a
...@@ -606,7 +606,6 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter) ...@@ -606,7 +606,6 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter)
struct ixgbe_ring *rx_ring; struct ixgbe_ring *rx_ring;
union ixgbe_adv_rx_desc *rx_desc; union ixgbe_adv_rx_desc *rx_desc;
struct ixgbe_rx_buffer *rx_buffer_info; struct ixgbe_rx_buffer *rx_buffer_info;
u32 staterr;
int i = 0; int i = 0;
if (!netif_msg_hw(adapter)) if (!netif_msg_hw(adapter))
...@@ -827,8 +826,7 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter) ...@@ -827,8 +826,7 @@ static void ixgbe_dump(struct ixgbe_adapter *adapter)
rx_buffer_info = &rx_ring->rx_buffer_info[i]; rx_buffer_info = &rx_ring->rx_buffer_info[i];
rx_desc = IXGBE_RX_DESC(rx_ring, i); rx_desc = IXGBE_RX_DESC(rx_ring, i);
u0 = (struct my_u0 *)rx_desc; u0 = (struct my_u0 *)rx_desc;
staterr = le32_to_cpu(rx_desc->wb.upper.status_error); if (rx_desc->wb.upper.length) {
if (staterr & IXGBE_RXD_STAT_DD) {
/* Descriptor Done */ /* Descriptor Done */
pr_info("RWB[0x%03X] %016llX %016llX ---------------- %p%s\n", pr_info("RWB[0x%03X] %016llX %016llX ---------------- %p%s\n",
i, i,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment