Commit 19926968 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso

netfilter: x_tables: cap allocations at 512 mbyte

Arbitrary limit, however, this still allows huge rulesets
(> 1 million rules).  This helps with automated fuzzer as it prevents
oom-killer invocation.
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent e816a2ce
...@@ -40,6 +40,7 @@ MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>"); ...@@ -40,6 +40,7 @@ MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>");
MODULE_DESCRIPTION("{ip,ip6,arp,eb}_tables backend module"); MODULE_DESCRIPTION("{ip,ip6,arp,eb}_tables backend module");
#define XT_PCPU_BLOCK_SIZE 4096 #define XT_PCPU_BLOCK_SIZE 4096
#define XT_MAX_TABLE_SIZE (512 * 1024 * 1024)
struct compat_delta { struct compat_delta {
unsigned int offset; /* offset in kernel */ unsigned int offset; /* offset in kernel */
...@@ -1117,7 +1118,7 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size) ...@@ -1117,7 +1118,7 @@ struct xt_table_info *xt_alloc_table_info(unsigned int size)
struct xt_table_info *info = NULL; struct xt_table_info *info = NULL;
size_t sz = sizeof(*info) + size; size_t sz = sizeof(*info) + size;
if (sz < sizeof(*info)) if (sz < sizeof(*info) || sz >= XT_MAX_TABLE_SIZE)
return NULL; return NULL;
/* __GFP_NORETRY is not fully supported by kvmalloc but it should /* __GFP_NORETRY is not fully supported by kvmalloc but it should
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment