Commit 1a0f7d29 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller

net: cls_u32: fix error code for invalid flags

'err' variable is not set in this test, we would return whatever
previous test set 'err' to.
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: default avatarSridhar Samudrala <sridhar.samudrala@intel.com>
Acked-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7b01b8e8
...@@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, ...@@ -863,7 +863,7 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
if (tb[TCA_U32_FLAGS]) { if (tb[TCA_U32_FLAGS]) {
flags = nla_get_u32(tb[TCA_U32_FLAGS]); flags = nla_get_u32(tb[TCA_U32_FLAGS]);
if (!tc_flags_valid(flags)) if (!tc_flags_valid(flags))
return err; return -EINVAL;
} }
n = (struct tc_u_knode *)*arg; n = (struct tc_u_knode *)*arg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment