Commit 1a234acc authored by Tudor Ambarus's avatar Tudor Ambarus Committed by Mark Brown

spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout()

ETIMEDOUT is more specific than EIO, use it for
wait_for_completion_timeout().
Reviewed-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20240207120431.2766269-14-tudor.ambarus@linaro.orgSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4c645205
...@@ -527,7 +527,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, ...@@ -527,7 +527,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,
/* /*
* If the previous xfer was completed within timeout, then * If the previous xfer was completed within timeout, then
* proceed further else return -EIO. * proceed further else return -ETIMEDOUT.
* DmaTx returns after simply writing data in the FIFO, * DmaTx returns after simply writing data in the FIFO,
* w/o waiting for real transmission on the bus to finish. * w/o waiting for real transmission on the bus to finish.
* DmaRx returns only after Dma read data from FIFO which * DmaRx returns only after Dma read data from FIFO which
...@@ -548,7 +548,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, ...@@ -548,7 +548,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,
/* If timed out while checking rx/tx status return error */ /* If timed out while checking rx/tx status return error */
if (!val) if (!val)
return -EIO; return -ETIMEDOUT;
return 0; return 0;
} }
...@@ -578,7 +578,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd, ...@@ -578,7 +578,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd,
if (use_irq) { if (use_irq) {
val = msecs_to_jiffies(ms); val = msecs_to_jiffies(ms);
if (!wait_for_completion_timeout(&sdd->xfer_completion, val)) if (!wait_for_completion_timeout(&sdd->xfer_completion, val))
return -EIO; return -ETIMEDOUT;
} }
val = msecs_to_loops(ms); val = msecs_to_loops(ms);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment