Commit 1a392b3d authored by Liu Jian's avatar Liu Jian Committed by Greg Kroah-Hartman

driver: uio: fix possible memory leak in __uio_register_device

'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b33 ("uio: Prevent device destruction while fds are open")
Signed-off-by: default avatarLiu Jian <liujian56@huawei.com>
Reviewed-by: default avatarHamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9bfd8198
...@@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner, ...@@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner,
atomic_set(&idev->event, 0); atomic_set(&idev->event, 0);
ret = uio_get_minor(idev); ret = uio_get_minor(idev);
if (ret) if (ret) {
kfree(idev);
return ret; return ret;
}
idev->dev.devt = MKDEV(uio_major, idev->minor); idev->dev.devt = MKDEV(uio_major, idev->minor);
idev->dev.class = &uio_class; idev->dev.class = &uio_class;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment