Commit 1ad61b61 authored by Sinan Kaya's avatar Sinan Kaya Committed by Bjorn Helgaas

PCI/ACPI: Correct error message for ASPM disabling

If _OSC execution fails today for platforms without an _OSC entry, code is
printing a misleading message saying disabling ASPM as follows:

  acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM

We need to ensure that platform supports ASPM to begin with.
Reported-by: default avatarMichael Kelley <mikelley@microsoft.com>
Signed-off-by: default avatarSinan Kaya <okaya@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent aeae4f3e
......@@ -455,8 +455,9 @@ static void negotiate_os_control(struct acpi_pci_root *root, int *no_aspm)
decode_osc_support(root, "OS supports", support);
status = acpi_pci_osc_support(root, support);
if (ACPI_FAILURE(status)) {
dev_info(&device->dev, "_OSC failed (%s); disabling ASPM\n",
acpi_format_exception(status));
dev_info(&device->dev, "_OSC failed (%s)%s\n",
acpi_format_exception(status),
pcie_aspm_support_enabled() ? "; disabling ASPM" : "");
*no_aspm = 1;
return;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment