Commit 1bd09ddc authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] drxk: fix warning: ‘status’ may be used uninitialized in this function

One of the problems of the old CHECK_ERROR is that it was hiding
the status parameter. Maybe due to that, on a few places, the return
code might lead to return incorrect status:

drivers/media/dvb/frontends/drxk_hard.c: In function ‘load_microcode.clone.0’:
drivers/media/dvb/frontends/drxk_hard.c:1281: warning: ‘status’ may be used uninitialized in this function
drivers/media/dvb/frontends/drxk_hard.c:1281: note: ‘status’ was declared here
drivers/media/dvb/frontends/drxk_hard.c: In function ‘GetLockStatus’:
drivers/media/dvb/frontends/drxk_hard.c:1792: warning: ‘status’ may be used uninitialized in this function
drivers/media/dvb/frontends/drxk_hard.c: In function ‘Start.clone.7’:
drivers/media/dvb/frontends/drxk_hard.c:1734: warning: ‘status’ may be used uninitialized in this function
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent e16cede5
...@@ -1278,7 +1278,7 @@ static int DownloadMicrocode(struct drxk_state *state, ...@@ -1278,7 +1278,7 @@ static int DownloadMicrocode(struct drxk_state *state,
u16 BlockCRC; u16 BlockCRC;
u32 offset = 0; u32 offset = 0;
u32 i; u32 i;
int status; int status = 0;
/* down the drain (we don care about MAGIC_WORD) */ /* down the drain (we don care about MAGIC_WORD) */
Drain = (pSrc[0] << 8) | pSrc[1]; Drain = (pSrc[0] << 8) | pSrc[1];
...@@ -1731,7 +1731,7 @@ static int SetOperationMode(struct drxk_state *state, ...@@ -1731,7 +1731,7 @@ static int SetOperationMode(struct drxk_state *state,
static int Start(struct drxk_state *state, s32 offsetFreq, static int Start(struct drxk_state *state, s32 offsetFreq,
s32 IntermediateFrequency) s32 IntermediateFrequency)
{ {
int status; int status = 0;
do { do {
u16 IFreqkHz; u16 IFreqkHz;
...@@ -1789,7 +1789,7 @@ static int ShutDown(struct drxk_state *state) ...@@ -1789,7 +1789,7 @@ static int ShutDown(struct drxk_state *state)
static int GetLockStatus(struct drxk_state *state, u32 *pLockStatus, static int GetLockStatus(struct drxk_state *state, u32 *pLockStatus,
u32 Time) u32 Time)
{ {
int status; int status = 0;
if (pLockStatus == NULL) if (pLockStatus == NULL)
return -1; return -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment