Commit 1ccbad9f authored by Peng Tao's avatar Peng Tao Committed by Trond Myklebust

nfs: fix DIO good bytes calculation

For direct read that has IO size larger than rsize, we'll split
it into several READ requests and nfs_direct_good_bytes() would
count completed bytes incorrectly by eating last zero count reply.

Fix it by handling mirror and non-mirror cases differently such that
we only count mirrored writes differently.

This fixes 5fadeb47("nfs: count DIO good bytes correctly with mirroring").
Reported-by: default avatarJean Spector <jean@primarydata.com>
Cc: <stable@vger.kernel.org> # v3.19+
Signed-off-by: default avatarPeng Tao <tao.peng@primarydata.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent ea96d1ec
...@@ -131,20 +131,25 @@ nfs_direct_good_bytes(struct nfs_direct_req *dreq, struct nfs_pgio_header *hdr) ...@@ -131,20 +131,25 @@ nfs_direct_good_bytes(struct nfs_direct_req *dreq, struct nfs_pgio_header *hdr)
WARN_ON_ONCE(hdr->pgio_mirror_idx >= dreq->mirror_count); WARN_ON_ONCE(hdr->pgio_mirror_idx >= dreq->mirror_count);
count = dreq->mirrors[hdr->pgio_mirror_idx].count; if (dreq->mirror_count == 1) {
if (count + dreq->io_start < hdr->io_start + hdr->good_bytes) { dreq->mirrors[hdr->pgio_mirror_idx].count += hdr->good_bytes;
count = hdr->io_start + hdr->good_bytes - dreq->io_start; dreq->count += hdr->good_bytes;
dreq->mirrors[hdr->pgio_mirror_idx].count = count; } else {
} /* mirrored writes */
count = dreq->mirrors[hdr->pgio_mirror_idx].count;
/* update the dreq->count by finding the minimum agreed count from all if (count + dreq->io_start < hdr->io_start + hdr->good_bytes) {
* mirrors */ count = hdr->io_start + hdr->good_bytes - dreq->io_start;
count = dreq->mirrors[0].count; dreq->mirrors[hdr->pgio_mirror_idx].count = count;
}
/* update the dreq->count by finding the minimum agreed count from all
* mirrors */
count = dreq->mirrors[0].count;
for (i = 1; i < dreq->mirror_count; i++) for (i = 1; i < dreq->mirror_count; i++)
count = min(count, dreq->mirrors[i].count); count = min(count, dreq->mirrors[i].count);
dreq->count = count; dreq->count = count;
}
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment