Commit 1d0f874b authored by Si-Wei Liu's avatar Si-Wei Liu Committed by Michael S. Tsirkin

vhost-vdpa: reset vendor specific mapping to initial state in .release

Devices with on-chip IOMMU or vendor specific IOTLB implementation may
need to restore iotlb mapping to the initial or default state using the
.reset_map op, as it's desirable for some parent devices to not work
with DMA ops and maintain a simple IOMMU model with .reset_map. In
particular, device reset should not cause mapping to go away on such
IOTLB model, so persistent mapping is implied across reset. Before the
userspace process using vhost-vdpa is gone, give it a chance to reset
iotlb back to the initial state in vhost_vdpa_cleanup().
Signed-off-by: default avatarSi-Wei Liu <si-wei.liu@oracle.com>
Acked-by: default avatarEugenio Pérez <eperezma@redhat.com>
Message-Id: <1697880319-4937-3-git-send-email-si-wei.liu@oracle.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Tested-by: default avatarLei Yang <leiyang@redhat.com>
parent d2cf1b6e
...@@ -131,6 +131,15 @@ static struct vhost_vdpa_as *vhost_vdpa_find_alloc_as(struct vhost_vdpa *v, ...@@ -131,6 +131,15 @@ static struct vhost_vdpa_as *vhost_vdpa_find_alloc_as(struct vhost_vdpa *v,
return vhost_vdpa_alloc_as(v, asid); return vhost_vdpa_alloc_as(v, asid);
} }
static void vhost_vdpa_reset_map(struct vhost_vdpa *v, u32 asid)
{
struct vdpa_device *vdpa = v->vdpa;
const struct vdpa_config_ops *ops = vdpa->config;
if (ops->reset_map)
ops->reset_map(vdpa, asid);
}
static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid) static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid)
{ {
struct vhost_vdpa_as *as = asid_to_as(v, asid); struct vhost_vdpa_as *as = asid_to_as(v, asid);
...@@ -140,6 +149,14 @@ static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid) ...@@ -140,6 +149,14 @@ static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid)
hlist_del(&as->hash_link); hlist_del(&as->hash_link);
vhost_vdpa_iotlb_unmap(v, &as->iotlb, 0ULL, 0ULL - 1, asid); vhost_vdpa_iotlb_unmap(v, &as->iotlb, 0ULL, 0ULL - 1, asid);
/*
* Devices with vendor specific IOMMU may need to restore
* iotlb to the initial or default state, which cannot be
* cleaned up in the all range unmap call above. Give them
* a chance to clean up or reset the map to the desired
* state.
*/
vhost_vdpa_reset_map(v, asid);
kfree(as); kfree(as);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment