Commit 1d1ceac4 authored by Xu Wang's avatar Xu Wang Committed by Kelsey Skunberg

clk: clk-atlas6: fix return value check in atlas6_clk_init()

BugLink: https://bugs.launchpad.net/bugs/1892822

[ Upstream commit 12b90b40 ]

In case of error, the function clk_register() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: default avatarXu Wang <vulab@iscas.ac.cn>
Link: https://lore.kernel.org/r/20200713032143.21362-1-vulab@iscas.ac.cnAcked-by: default avatarBarry Song <baohua@kernel.org>
Fixes: 7bf21bc8 ("clk: sirf: re-arch to make the codes support both prima2 and atlas6")
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarIan May <ian.may@canonical.com>
Signed-off-by: default avatarKelsey Skunberg <kelsey.skunberg@canonical.com>
parent bce989ca
...@@ -137,7 +137,7 @@ static void __init atlas6_clk_init(struct device_node *np) ...@@ -137,7 +137,7 @@ static void __init atlas6_clk_init(struct device_node *np)
for (i = pll1; i < maxclk; i++) { for (i = pll1; i < maxclk; i++) {
atlas6_clks[i] = clk_register(NULL, atlas6_clk_hw_array[i]); atlas6_clks[i] = clk_register(NULL, atlas6_clk_hw_array[i]);
BUG_ON(!atlas6_clks[i]); BUG_ON(IS_ERR(atlas6_clks[i]));
} }
clk_register_clkdev(atlas6_clks[cpu], NULL, "cpu"); clk_register_clkdev(atlas6_clks[cpu], NULL, "cpu");
clk_register_clkdev(atlas6_clks[io], NULL, "io"); clk_register_clkdev(atlas6_clks[io], NULL, "io");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment