Commit 1d38b4e9 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mark Brown

ASoC: xlnx: fix error handling in xlnx_formatter_pcm_probe

Currently, if platform_get_irq_byname() fails, the returned error
turns into a huge value, once it is being store into a variable
of type unsigned int, hence never actually reporting any error
and causing unexpected behavior when using the values stored
in aud_drv_data->s2mm_irq and aud_drv_data->mm2s_irq.

Fix this by changing the type of variables s2mm_irq and mm2s_irq in
structure xlnx_pcm_drv_data from unsigned int to int.

Addresses-Coverity-ID: 1476096 ("Unsigned compared against 0")
Fixes: 796175a94a7f ("ASoC: xlnx: add pcm formatter platform driver")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f5758544
...@@ -76,8 +76,8 @@ struct xlnx_pcm_drv_data { ...@@ -76,8 +76,8 @@ struct xlnx_pcm_drv_data {
void __iomem *mmio; void __iomem *mmio;
bool s2mm_presence; bool s2mm_presence;
bool mm2s_presence; bool mm2s_presence;
unsigned int s2mm_irq; int s2mm_irq;
unsigned int mm2s_irq; int mm2s_irq;
struct snd_pcm_substream *play_stream; struct snd_pcm_substream *play_stream;
struct snd_pcm_substream *capture_stream; struct snd_pcm_substream *capture_stream;
struct clk *axi_clk; struct clk *axi_clk;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment