powerpc/iseries: Fix oops reading from /proc/iSeries/mf/*/cmdline

That code uses dma_mapping_error() with a NULL device, which is
a bad idea :-) The proper fix might be to start using some kind
of pseudo device for all these low level mappings with the
hypervisor but that will be for another day. Since it directly
calls into the low level iommu code, I see no problem in having
it directly test against DMA_ERROR_CODE instead of using the
accessors with a NULL argument for now.
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent bc00351e
...@@ -872,7 +872,7 @@ static int proc_mf_dump_cmdline(char *page, char **start, off_t off, ...@@ -872,7 +872,7 @@ static int proc_mf_dump_cmdline(char *page, char **start, off_t off,
count = 256 - off; count = 256 - off;
dma_addr = iseries_hv_map(page, off + count, DMA_FROM_DEVICE); dma_addr = iseries_hv_map(page, off + count, DMA_FROM_DEVICE);
if (dma_mapping_error(NULL, dma_addr)) if (dma_addr == DMA_ERROR_CODE)
return -ENOMEM; return -ENOMEM;
memset(page, 0, off + count); memset(page, 0, off + count);
memset(&vsp_cmd, 0, sizeof(vsp_cmd)); memset(&vsp_cmd, 0, sizeof(vsp_cmd));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment