Commit 1d7db834 authored by Kefeng Wang's avatar Kefeng Wang Committed by Christoph Hellwig

dma-debug: use memory_intersects() directly

There is already a memory_intersects() helper in sections.h,
use memory_intersects() directly instead of private overlap().
Signed-off-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 36a21d51
...@@ -1064,20 +1064,10 @@ static void check_for_stack(struct device *dev, ...@@ -1064,20 +1064,10 @@ static void check_for_stack(struct device *dev,
} }
} }
static inline bool overlap(void *addr, unsigned long len, void *start, void *end)
{
unsigned long a1 = (unsigned long)addr;
unsigned long b1 = a1 + len;
unsigned long a2 = (unsigned long)start;
unsigned long b2 = (unsigned long)end;
return !(b1 <= a2 || a1 >= b2);
}
static void check_for_illegal_area(struct device *dev, void *addr, unsigned long len) static void check_for_illegal_area(struct device *dev, void *addr, unsigned long len)
{ {
if (overlap(addr, len, _stext, _etext) || if (memory_intersects(_stext, _etext, addr, len) ||
overlap(addr, len, __start_rodata, __end_rodata)) memory_intersects(__start_rodata, __end_rodata, addr, len))
err_printk(dev, NULL, "device driver maps memory from kernel text or rodata [addr=%p] [len=%lu]\n", addr, len); err_printk(dev, NULL, "device driver maps memory from kernel text or rodata [addr=%p] [len=%lu]\n", addr, len);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment