Commit 1d8c2aea authored by Colin Ian King's avatar Colin Ian King Committed by Kleber Sacilotto de Souza

ipv6: fix useless rol32 call on hash

BugLink: https://bugs.launchpad.net/bugs/1791080

[ Upstream commit 169dc027 ]

The rol32 call is currently rotating hash but the rol'd value is
being discarded. I believe the current code is incorrect and hash
should be assigned the rotated value returned from rol32.

Thanks to David Lebrun for spotting this.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent fe806eb8
...@@ -762,7 +762,7 @@ static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff *skb, ...@@ -762,7 +762,7 @@ static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff *skb,
* to minimize possbility that any useful information to an * to minimize possbility that any useful information to an
* attacker is leaked. Only lower 20 bits are relevant. * attacker is leaked. Only lower 20 bits are relevant.
*/ */
rol32(hash, 16); hash = rol32(hash, 16);
flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK; flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment