Commit 1d8e5c00 authored by Minas Harutyunyan's avatar Minas Harutyunyan Committed by Felipe Balbi

dwc2: gadget: Fix ISOC IN DDMA PID bitfield value calculation

PID bitfield in descriptor should be set based on particular request
length, not based on EP's mc value. PID value can't be set to 0 even
request length is 0.
Signed-off-by: default avatarMinas Harutyunyan <hminas@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 9bb073a0
...@@ -812,6 +812,7 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep, ...@@ -812,6 +812,7 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
u32 index; u32 index;
u32 maxsize = 0; u32 maxsize = 0;
u32 mask = 0; u32 mask = 0;
u8 pid = 0;
maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask); maxsize = dwc2_gadget_get_desc_params(hs_ep, &mask);
...@@ -840,7 +841,11 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep, ...@@ -840,7 +841,11 @@ static int dwc2_gadget_fill_isoc_desc(struct dwc2_hsotg_ep *hs_ep,
((len << DEV_DMA_NBYTES_SHIFT) & mask)); ((len << DEV_DMA_NBYTES_SHIFT) & mask));
if (hs_ep->dir_in) { if (hs_ep->dir_in) {
desc->status |= ((hs_ep->mc << DEV_DMA_ISOC_PID_SHIFT) & if (len)
pid = DIV_ROUND_UP(len, hs_ep->ep.maxpacket);
else
pid = 1;
desc->status |= ((pid << DEV_DMA_ISOC_PID_SHIFT) &
DEV_DMA_ISOC_PID_MASK) | DEV_DMA_ISOC_PID_MASK) |
((len % hs_ep->ep.maxpacket) ? ((len % hs_ep->ep.maxpacket) ?
DEV_DMA_SHORT : 0) | DEV_DMA_SHORT : 0) |
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment