Commit 1eeb7e42 authored by Ralf Baechle's avatar Ralf Baechle Committed by David S. Miller

[BPQ] lockdep: fix false positive

Bpqether is encapsulating AX.25 frames into ethernet frames.  There is a
virtual bpqether device paired with each ethernet devices, so it's normal
to pass through dev_queue_xmit twice for each frame which triggers the
locking detector.
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7466d90f
...@@ -122,6 +122,12 @@ struct bpqdev { ...@@ -122,6 +122,12 @@ struct bpqdev {
static LIST_HEAD(bpq_devices); static LIST_HEAD(bpq_devices);
/*
* bpqether network devices are paired with ethernet devices below them, so
* form a special "super class" of normal ethernet devices; split their locks
* off into a separate class since they always nest.
*/
static struct lock_class_key bpq_netdev_xmit_lock_key;
/* ------------------------------------------------------------------------ */ /* ------------------------------------------------------------------------ */
...@@ -528,6 +534,7 @@ static int bpq_new_device(struct net_device *edev) ...@@ -528,6 +534,7 @@ static int bpq_new_device(struct net_device *edev)
err = register_netdevice(ndev); err = register_netdevice(ndev);
if (err) if (err)
goto error; goto error;
lockdep_set_class(&ndev->_xmit_lock, &bpq_netdev_xmit_lock_key);
/* List protected by RTNL */ /* List protected by RTNL */
list_add_rcu(&bpq->bpq_list, &bpq_devices); list_add_rcu(&bpq->bpq_list, &bpq_devices);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment