Commit 1f34cc4a authored by Shixin Liu's avatar Shixin Liu Committed by Herbert Xu

crypto: omap-aes - Fix PM reference leak on omap-aes.c

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Signed-off-by: default avatarShixin Liu <liushixin2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 13343bad
...@@ -103,9 +103,8 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd) ...@@ -103,9 +103,8 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd)
dd->err = 0; dd->err = 0;
} }
err = pm_runtime_get_sync(dd->dev); err = pm_runtime_resume_and_get(dd->dev);
if (err < 0) { if (err < 0) {
pm_runtime_put_noidle(dd->dev);
dev_err(dd->dev, "failed to get sync: %d\n", err); dev_err(dd->dev, "failed to get sync: %d\n", err);
return err; return err;
} }
...@@ -1134,7 +1133,7 @@ static int omap_aes_probe(struct platform_device *pdev) ...@@ -1134,7 +1133,7 @@ static int omap_aes_probe(struct platform_device *pdev)
pm_runtime_set_autosuspend_delay(dev, DEFAULT_AUTOSUSPEND_DELAY); pm_runtime_set_autosuspend_delay(dev, DEFAULT_AUTOSUSPEND_DELAY);
pm_runtime_enable(dev); pm_runtime_enable(dev);
err = pm_runtime_get_sync(dev); err = pm_runtime_resume_and_get(dev);
if (err < 0) { if (err < 0) {
dev_err(dev, "%s: failed to get_sync(%d)\n", dev_err(dev, "%s: failed to get_sync(%d)\n",
__func__, err); __func__, err);
...@@ -1303,7 +1302,7 @@ static int omap_aes_suspend(struct device *dev) ...@@ -1303,7 +1302,7 @@ static int omap_aes_suspend(struct device *dev)
static int omap_aes_resume(struct device *dev) static int omap_aes_resume(struct device *dev)
{ {
pm_runtime_get_sync(dev); pm_runtime_resume_and_get(dev);
return 0; return 0;
} }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment