Commit 1ffde03d authored by Ondrej Zary's avatar Ondrej Zary Committed by David S. Miller

3c503: fix broken IRQ autoprobing

Fix broken IRQ autoprobing in 3c503 driver:
 - improper IRQ freeing (does not free IRQs causes WARN)
 - missing break when an working IRQ is found

The driver works with this patch.
Signed-off-by: default avatarOndrej Zary <linux@rainbow-software.org>
Reviewed-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@conan.davemloft.net>
parent b9cabe52
...@@ -412,7 +412,7 @@ el2_open(struct net_device *dev) ...@@ -412,7 +412,7 @@ el2_open(struct net_device *dev)
outb_p(0x04 << ((*irqp == 9) ? 2 : *irqp), E33G_IDCFR); outb_p(0x04 << ((*irqp == 9) ? 2 : *irqp), E33G_IDCFR);
outb_p(0x00, E33G_IDCFR); outb_p(0x00, E33G_IDCFR);
msleep(1); msleep(1);
free_irq(*irqp, el2_probe_interrupt); free_irq(*irqp, &seen);
if (!seen) if (!seen)
continue; continue;
...@@ -422,6 +422,7 @@ el2_open(struct net_device *dev) ...@@ -422,6 +422,7 @@ el2_open(struct net_device *dev)
continue; continue;
if (retval < 0) if (retval < 0)
goto err_disable; goto err_disable;
break;
} while (*++irqp); } while (*++irqp);
if (*irqp == 0) { if (*irqp == 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment